Skip to content

fix: fix mypy#15496

Merged
parthea merged 1 commit intomainfrom
fix-mypy-grafeas
Jan 30, 2026
Merged

fix: fix mypy#15496
parthea merged 1 commit intomainfrom
fix-mypy-grafeas

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 30, 2026 •
edited
Loading

Towards #15104

This is needed to unblock #15457 .

See follow up issue googleapis/proto-plus-python#558 for the prerelease presubmit failure.

See the following mypy failure for grafeas

2026-01-16T22:02:28.7158467Z grafeas/grafeas_v1/services/grafeas/client.py:362: error: Incompatible default for argument "transport" (default has type "None", argument has type "str | GrafeasTransport")

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on resolving mypy type checking issues by refining the type annotation for the transport parameter within the GrafeasClient initialization. By explicitly marking this parameter as Optional, the code now correctly communicates that None is an acceptable value, leading to cleaner static analysis results and improved code clarity.

Highlights

  • Type Hint Correction: The type annotation for the transport parameter in the GrafeasClient constructor has been updated to explicitly include Optional. This change ensures that the parameter can correctly accept None as a value.
  • Mypy Compliance: This modification addresses mypy static analysis warnings or errors by providing a more accurate type hint, improving the overall type-checking integrity of the codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 30, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a mypy issue by explicitly defining the transport parameter as Optional. The change is correctly applied to both the generator configuration and the resulting Python client code, ensuring consistency. The change is straightforward and improves type hint clarity. Looks good to me.

@parthea parthea marked this pull request as ready for review January 30, 2026 19:56
@parthea parthea requested review from a team as code owners January 30, 2026 19:56
@parthea parthea merged commit 4daf9cc into main Jan 30, 2026
25 of 26 checks passed
@parthea parthea deleted the fix-mypy-grafeas branch January 30, 2026 20:01
@cloud-sdk-librarian-robot cloud-sdk-librarian-robot mentioned this pull request Feb 5, 2026
Merged
ohmayr pushed a commit that referenced this pull request Feb 5, 2026
@cloud-sdk-librarian-robot
chore: librarian release pull request: 20260205T080503Z (#15528)
b99ac6a 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.0.0-20251218164811-cd2252e38d0a
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:d3ae275c61acca91e1398581edfb9119c521b4e93f9ebb00ecbd4e87b71648f5
<details><summary>google-ads-datamanager: 0.4.0</summary>

##
[0.4.0](google-ads-datamanager-v0.3.0...google-ads-datamanager-v0.4.0)
(2026-02-05)

### Bug Fixes

* update `go_package` packaging option from
`google.golang.org/genproto/googleapis/ads/datamanager/v1;datamanager`
to `cloud.google.com/go/datamanager/apiv1/datamanagerpb;datamanagerpb`
(PiperOrigin-RevId: 863287879)
([fe0a0b4](fe0a0b46))

### Documentation

* describe additional URI format for kek_uri in GcpEncryptionInfo and
AwsKmsEncryptionInfo (PiperOrigin-RevId: 863287879)
([fe0a0b4](fe0a0b46))

</details>


<details><summary>google-apps-card: 0.5.0</summary>

##
[0.5.0](google-apps-card-v0.4.0...google-apps-card-v0.5.0)
(2026-02-05)

### Documentation

* update reference documentation for `SelectionInput.DROPDOWN` to
include dynamic data sources and autosuggestion (PiperOrigin-RevId:
864941572)
([fe0a0b4](fe0a0b46))

* update copyright to 2026 (PiperOrigin-RevId: 864941572)
([fe0a0b4](fe0a0b46))

</details>


<details><summary>google-apps-chat: 0.6.0</summary>

##
[0.6.0](google-apps-chat-v0.5.0...google-apps-chat-v0.6.0)
(2026-02-05)

### Features

* Addition of QuoteType enum, QuotedMessageSnapshot &amp;amp;
ForwardMetadata in the QuotedMessageMetadata proto (PiperOrigin-RevId:
864426372)
([fe0a0b4](fe0a0b46))

</details>


<details><summary>google-cloud-apiregistry: 0.1.0</summary>

##
[0.1.0](google-cloud-apiregistry-v0.0.0...google-cloud-apiregistry-v0.1.0)
(2026-02-05)

### Features

* onboard a new library (PiperOrigin-RevId: 848064295)
([6837229](68372299))

</details>


<details><summary>google-cloud-auditmanager: 0.1.0</summary>

##
[0.1.0](google-cloud-auditmanager-v0.0.0...google-cloud-auditmanager-v0.1.0)
(2026-02-05)

### Features

* generate libraries (#15502) (PiperOrigin-RevId: 861758611)
([4997475](4997475a))

</details>


<details><summary>google-cloud-backupdr: 0.8.0</summary>

##
[0.8.0](google-cloud-backupdr-v0.7.0...google-cloud-backupdr-v0.8.0)
(2026-02-05)

### Features

* Add support for AlloyDB backup and restore (PiperOrigin-RevId:
862089230)
([fe0a0b4](fe0a0b46))

### Documentation

* A comment for field `log_retention_days` in message
`.google.cloud.backupdr.v1.BackupPlan` is changed (PiperOrigin-RevId:
862089230)
([fe0a0b4](fe0a0b46))

</details>


<details><summary>google-cloud-monitoring: 2.29.1</summary>

##
[2.29.1](google-cloud-monitoring-v2.29.0...google-cloud-monitoring-v2.29.1)
(2026-02-05)

### Bug Fixes

* fix mypy errors (#15494)
([1f4c286](1f4c2862))

</details>


<details><summary>google-cloud-monitoring-dashboards: 2.20.1</summary>

##
[2.20.1](google-cloud-monitoring-dashboards-v2.20.0...google-cloud-monitoring-dashboards-v2.20.1)
(2026-02-05)

### Bug Fixes

* fix mypy errors in
google-cloud-monitoring-dashboards/google/monitoring (#15493)
([ca15a7e](ca15a7e6))

</details>


<details><summary>google-cloud-org-policy: 1.16.1</summary>

##
[1.16.1](google-cloud-org-policy-v1.16.0...google-cloud-org-policy-v1.16.1)
(2026-02-05)

### Bug Fixes

* fix mypy errors (#15494)
([1f4c286](1f4c2862))

</details>


<details><summary>google-cloud-quotas: 0.5.0</summary>

##
[0.5.0](google-cloud-quotas-v0.4.0...google-cloud-quotas-v0.5.0)
(2026-02-05)

### Features

* Hierarchical Quota Adjuster (PiperOrigin-RevId: 863242165)
([fe0a0b4](fe0a0b46))

### Documentation

* Folder level and organization level support for the quota adjuster
feature. (PiperOrigin-RevId: 863242165)
([fe0a0b4](fe0a0b46))

</details>


<details><summary>google-cloud-speech: 2.36.1</summary>

##
[2.36.1](google-cloud-speech-v2.36.0...google-cloud-speech-v2.36.1)
(2026-02-05)

### Bug Fixes

* fix mypy errors (#15494)
([1f4c286](1f4c2862))

</details>


<details><summary>google-cloud-vectorsearch: 0.4.0</summary>

##
[0.4.0](google-cloud-vectorsearch-v0.3.0...google-cloud-vectorsearch-v0.4.0)
(2026-02-05)

### Features

* Allow requesting search metadata in SearchDataObjects
(PiperOrigin-RevId: 863352956)
([fe0a0b4](fe0a0b46))

* add filter param for TextSearch requests (PiperOrigin-RevId:
863352956)
([fe0a0b4](fe0a0b46))

* add SearchHint to SemanticSearch requests (PiperOrigin-RevId:
863352956)
([fe0a0b4](fe0a0b46))

* add ExportDataObjects API (PiperOrigin-RevId: 863352956)
([fe0a0b4](fe0a0b46))

</details>


<details><summary>google-cloud-vision: 3.12.1</summary>

##
[3.12.1](google-cloud-vision-v3.12.0...google-cloud-vision-v3.12.1)
(2026-02-05)

### Bug Fixes

* fix mypy errors (#15494)
([1f4c286](1f4c2862))

</details>


<details><summary>grafeas: 1.19.1</summary>

##
[1.19.1](grafeas-v1.19.0...grafeas-v1.19.1)
(2026-02-05)

### Bug Fixes

* fix mypy (#15496)
([4daf9cc](4daf9cc2))

</details>


<details><summary>Bulk Changes</summary>

* chore: librarian update image pull request: 20260123T001116Z (#15481)
([871cdee](871cdeeb))
Libraries:
google-ads-datamanager,google-apps-card,google-apps-chat,google-cloud-backupdr,google-cloud-monitoring,google-cloud-monitoring-dashboards,google-cloud-org-policy,google-cloud-speech,google-cloud-vectorsearch,google-cloud-vision
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @daniel-sanche